Fix memory leaks in SecEntity structure for XrdHttp. #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please backport to 4.6.x series too - we're observing these memory leaks in the wild! |
|
Hi Brian,
Given that 4.6.0 less than ideal (putting it mildly) there doesn’t seem much reason to back port to it as we would prefer people not run it in the first place. How about 4.6.1?
Andy
From: Brian Bockelman
Sent: Monday, April 03, 2017 7:36 AM
To: xrootd/xrootd
Cc: Subscribed
Subject: Re: [xrootd/xrootd] Fix memory leaks in SecEntity structure for XrdHttp. (#493)
Please backport to 4.6.x series too - we're observing these memory leaks in the wild!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yup, that's that's what I intended to mean by suggesting a backport to |
|
Fabrizio merged this fix into his pull request, so no need to merge this one. |
|
Actually, talking about 4.6.1; we are thinking of just releasing 4.7.0 as we have accumulated a lot of new stuff (mostly systemd related stuff). We might not but just wanted o give you a heads up in case you have thoughts about it.
Andy
From: Brian Bockelman
Sent: Monday, April 03, 2017 8:29 PM
To: xrootd/xrootd
Cc: Andrew Hanushevsky ; Comment
Subject: Re: [xrootd/xrootd] Fix memory leaks in SecEntity structure for XrdHttp. (#493)
Yup, that's that's what I intended to mean by suggesting a backport to 4.6.x series. I just didn't want to wait for 4.7.0 for this fix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems:
SecEntitycleanup code inXrdHttpdid not clean up two fields of the data structure.